Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEB-2459] Fix: analytics scroll + dashboard stat minor padding #5613

Merged
merged 3 commits into from
Sep 17, 2024
Merged

[WEB-2459] Fix: analytics scroll + dashboard stat minor padding #5613

merged 3 commits into from
Sep 17, 2024

Conversation

gakshita
Copy link
Collaborator

@gakshita gakshita commented Sep 16, 2024 •
edited by coderabbitai bot
Loading

Summary

  • Scrolling on analytics page fixed
  • Minor padding on dashboard page overview stat fixed

[WEB-2459]

Summary by CodeRabbit

  • New Features

    • Enhanced layout and styling of the CustomAnalytics, CustomAnalyticsSelectBar, AnalyticsTable, OverviewStatsWidget, and WorkspaceDashboardView components for improved user experience.

  • Style

    • Updated CSS classes for better visual presentation and spacing across various components, including adjustments to padding and corner rounding.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 16, 2024 •
edited
Loading

Walkthrough

The pull request introduces several modifications to various components within the analytics and dashboard sections of the application. Key changes include the replacement of the ContentWrapper component with a div in the CustomAnalytics component, the use of a <Row> component in the CustomAnalyticsSelectBar, and adjustments to CSS classes in the OverviewStatsWidget. These changes primarily focus on enhancing layout and styling without altering the core functionality of the components.

Changes

File Path Change Summary
web/core/components/analytics/custom-analytics/*.tsx - Replaced ContentWrapper with a div in CustomAnalytics.
- Changed outer <div> to <Row> in CustomAnalyticsSelectBar, modifying padding classes.
- Removed absolute left-0 class from AnalyticsTable.
web/core/components/dashboard/widgets/overview-stats.tsx - Updated Card CSS classes in OverviewStatsWidget, adding padding and changing corner rounding classes.
web/core/components/page-views/workspace-dashboard.tsx - Added bg-custom-background-90 class to ContentWrapper in WorkspaceDashboardView.

Possibly related PRs

Suggested labels

🌐frontend, 🧹chore

🐇 In the garden where changes bloom,
A div takes place, dispelling gloom.
Rows align with style anew,
Padding whispers, "Look at you!"
Widgets dance in rounded grace,
A vibrant dashboard finds its place! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sriramveeraghanta sriramveeraghanta merged commit 7aea820 into preview Sep 17, 2024
13 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-analytics-scroll branch September 17, 2024 11:03
This was referenced Sep 18, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulramesha rahulramesha rahulramesha approved these changes

@SatishGandham SatishGandham Awaiting requested review from SatishGandham

@pushya22 pushya22 Awaiting requested review from pushya22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gakshita @SatishGandham @rahulramesha @pushya22 @sriramveeraghanta